This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
Ctrl/cmd a behaviour web #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
January 31, 2023 10:16
3 tasks
|
Just putting back into draft whilst I appease SonarCloud |
|
SonarCloud Quality Gate failed. |
|
If I check the coverage locally, it doesn't match the issues that SonarCloud is showing, I'm not sure what is going on there |
The CI doesn't run the coverage however the report is sent to sonar. |
florianduros
approved these changes
Feb 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close issue 540.
The fix for the cmd a behaviour is small, we just needed to count the extra offsets that are introduced by certain tags after the paragraph refactor.
That work, however, made me realise that a lot of the dom tests for
getCurrentSelectionneeded rewriting as they no longer represented what a user would be writing in the composer. This is why the diff is so large.Behaviour:
Screen.Recording.2023-02-01.at.10.36.04.mov