Post-repo-split work #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
force-pushed
the
jplatte/post-split
branch
from
a13f64d
to
ee6950f
Compare
… the latest release seems buggy.
richvdh
approved these changes
Jul 13, 2023
| @@ -1,6 +1,6 @@ | |||
| //! Types related to events. | |||
|
|
|||
| use ruma::events::room::history_visibility::HistoryVisibility as RumaHistoryVisibility; | |||
| use matrix_sdk_common::ruma::events::room::history_visibility::HistoryVisibility as RumaHistoryVisibility; | |||
There was a problem hiding this comment.
bit surprised about this. Why is using matrix_sdk_common's re-export better than using ruma directly?
There was a problem hiding this comment.
Don't have to keep versions in sync by hand that way. Especially relevant when we're using a git dependency of Ruma in the SDK (which I hope to change soon-ish, but not exactly high priority as far as EX is concerned).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.