Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track whether we've ever verified another user, and later signal when that user becomes unverified for any reason #1129

Closed
Tracked by #2488
BillCarsonFr opened this issue Oct 20, 2022 · 3 comments · Fixed by #3795
Closed
Tracked by #2488

Track whether we've ever verified another user, and later signal when that user becomes unverified for any reason #1129

BillCarsonFr opened this issue Oct 20, 2022 · 3 comments · Fixed by #3795
Assignees
@BillCarsonFr
Labels
encryption
Milestone
Stabilize the cry...

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Oct 20, 2022 •
edited by richvdh
Loading

We should warn a user when the identity of a previously trusted user is rotated.

On android we expect to be able to map that in MXCrossSIgningInfo#wasTrustedOnce
On pre-element-R web, this is implemented at https://github.com/matrix-org/matrix-js-sdk/blob/0f08c00c07b9495dd9b8b11f6bc2a8cd0ca105e9/src/crypto/CrossSigning.ts#L62-L67
@BillCarsonFr BillCarsonFr changed the title Warn on cross signing reset Warn on other user cross signing reset Jul 25, 2024
@BillCarsonFr
Copy link
Member Author

BillCarsonFr commented Jul 26, 2024 •
edited by richvdh
Loading

For context the old android (native crypto stack) Issue and PR to fix similar issue: element-hq/element-android#6702

@BillCarsonFr BillCarsonFr changed the title Warn on other user cross signing reset Tracks whether we've ever verified another user, and later signal went that user becomes unverified for any reason. Jul 26, 2024
@BillCarsonFr BillCarsonFr changed the title Tracks whether we've ever verified another user, and later signal went that user becomes unverified for any reason. Tracks whether we've ever verified another user, and later signal when that user becomes unverified for any reason. Jul 26, 2024
@BillCarsonFr BillCarsonFr self-assigned this Jul 26, 2024
@richvdh richvdh changed the title Tracks whether we've ever verified another user, and later signal when that user becomes unverified for any reason. Track whether we've ever verified another user, and later signal when that user becomes unverified for any reason Jul 26, 2024
@richvdh
Copy link
Member

richvdh commented Jul 31, 2024

I believe this is part of element-hq/element-meta#2488 ?

@richvdh richvdh mentioned this issue Jul 31, 2024
Closed
@richvdh
Copy link
Member

richvdh commented Aug 1, 2024

In the weekly meeting, @BillCarsonFr said that this is in progress. Updating its state on the sprint board.

This was referenced Aug 1, 2024
Closed
Closed
BillCarsonFr added a commit that referenced this issue Aug 2, 2024
@BillCarsonFr
crypto: Remember and detect verified identity changes for #1129
fbc4f2d
@BillCarsonFr BillCarsonFr mentioned this issue Aug 2, 2024
Merged
1 task
BillCarsonFr added a commit that referenced this issue Aug 2, 2024
@BillCarsonFr
crypto: Remember and detect verified identity changes for #1129
55998db
@BillCarsonFr BillCarsonFr mentioned this issue Aug 7, 2024
Open
BillCarsonFr added a commit that referenced this issue Aug 7, 2024
@BillCarsonFr
crypto: Remember and detect verified identity changes for #1129
b4fe305
@BillCarsonFr BillCarsonFr mentioned this issue Sep 17, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
encryption
Projects
None yet
Milestone
Stabilize the crypto crate
Development

Successfully merging a pull request may close this issue.

Crypto | Add support for verified identities change detection. matrix-org/matrix-rust-sdk
2 participants
@richvdh @BillCarsonFr