Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add unit tests for the CryptoStoreLock #2167

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jun 27, 2023

This adds a few unit tests for the CryptoStoreLock. I was sure I wrote this before, but apparently it hasn't been the case 🙃

@bnjbvr bnjbvr requested a review from a team as a code owner June 27, 2023 15:49
@bnjbvr bnjbvr requested review from Hywan and removed request for a team June 27, 2023 15:49
@bnjbvr bnjbvr mentioned this pull request Jun 19, 2023
11 tasks
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18 🎉

Comparison is base (49b1e87) 76.08% compared to head (abab193) 76.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2167      +/-   ##
==========================================
+ Coverage   76.08%   76.27%   +0.18%     
==========================================
  Files         163      163              
  Lines       17280    17279       -1     
==========================================
+ Hits        13148    13179      +31     
+ Misses       4132     4100      -32     
Impacted Files Coverage Δ
crates/matrix-sdk-crypto/src/store/locks.rs 96.72% <100.00%> (+49.94%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bnjbvr bnjbvr merged commit 459b689 into matrix-org:main Jun 29, 2023
47 checks passed
@bnjbvr bnjbvr deleted the add-tests-for-crypto-store-locks branch June 30, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants