crypto: crypto store wrapper migration framework #3800
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rust-sdk offers an abstraction of the persistence layer via the
CryptoStore
.There are several implementation, with each of them having their own migration framework to manage their internal data format.
There is some basic migration support at the OlmMachine layer via serde serialization/deserialization. Like for example the use of
#[serde(default)]
that allows to add a default static value for a field added in a json model, or Serialization helpers like for identity migration.But this only allows static/basic migration with no access to other existing data.
There is a need to be able to do more in a migration, like seen in this PR, were we are adding a new flag on identities that needs to access the current identity as well as the identity currently migrated. This can be solved by marking all users as dirty, and we have no way to do that currently (appart from doing it in each store implementation?)
This PR adds basic support for such migration.
It impacts a lots of files because the
CryptoStoreWrapper::new
function needs now to be asyncSigned-off-by: