MSC1730: Mechanism for redirecting to an alternative server during login (version 2) #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osal/cs_api_in_login" This reverts commit e30543a.
|
@mscbot fcp merge |
|
Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
mscbot
added
proposed-final-comment-period
anoadragon453
added
proposal
|
removing the labels since we're tracking this at #1730. |
richvdh
removed
T-Core
disposition-merge
proposed-final-comment-period
mscbot
added
the
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
richvdh
removed
the
final-comment-period
|
no, mscbot. |
|
I mean, it's just following orders. |
richvdh
reviewed
Dec 14, 2018
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
|
right, merging this as the FCP is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Note: This is me re-opening #1730 because I accidentally screwed up the final comment period process and merged it too early. Please leave feedback here, and consider this MSC1730. I haven't given this one the proposal labels to avoid it being picked up as a whole new proposal - please see 1730 for the right labels.
See #1730 (comment) for more information.