Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_known_event_id property #3986

Conversation

andybalaam
Copy link
Contributor

As agreed here: #3946 (comment)

@@ -49,6 +49,7 @@ key | type | value | description | required
--- | --- | --- | --- | ---
`predecessor_room_id` | string | Room ID | A reference to the room that came before and was replaced by this room | yes
`via_servers` | [string] | List of server names | The servers to attempt to join the room through. These servers should be participating in the room to be useful. This option is necessary since room ID's are not routable on their own.
`last_known_event_id` | string | Event ID | The event ID of the last known event in the old room
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this useful? We should continue the conversation in #3946 (comment)

Copy link
Contributor

@MadLittleMods MadLittleMods Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andybalaam Friendly poke to respond in the other thread ^ so we can close or merge this PR.

(we could close regardless in favor of just updating the original MSC after reaching a conclusion in that thread)

@turt2live
Copy link
Member

(both of you should also have push permissions on the MSC, and this seems small enough to fit into the "suggestions" feature on github: it's not cleart why this PR exists)

@andybalaam
Copy link
Contributor Author

(both of you should also have push permissions on the MSC, and this seems small enough to fit into the "suggestions" feature on github: it's not cleart why this PR exists)

Yeah I didn't think of using the suggestions feature. Is this PR's existence a problem?

@turt2live
Copy link
Member

Not a problem, just slightly awkward for tracking purposes :D

@turt2live
Copy link
Member

Closing in favour of further discussion on the MSC itself.

@turt2live turt2live closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants