Module template retrofit: GitHub metadata and Actions #142
Conversation
| matrix: | ||
| # Run the unit tests both against our oldest supported Python version | ||
| # and the newest stable. | ||
| python_version: [ "3.7", "3.x" ] |
There was a problem hiding this comment.
I have no idea what we currently support for this, but should we test 3.7 / 3.8 / 3.9 / 3.10?
There was a problem hiding this comment.
No objection to doing so, but for some reason we decided to do oldest+newest for modules. Was it perhaps because of the burden of updating the CI files for each release?
There was a problem hiding this comment.
(and current CI does Py 3.5 but I see no reason to support 3.5, 3.6 when Synapse itself isn't supported on those)
There was a problem hiding this comment.
That's fine! Wasn't sure if this was straight from the template or if you had modified it.
| @@ -1,2 +1,3 @@ | |||
|
|
|||
There was a problem hiding this comment.
I think this was done by mistake?
There was a problem hiding this comment.
The template emits it like that. I left it in because I thought having a zero diff is nice when the file is the same as what the template gives.
No description provided.