Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install deps and project in one go #4

Merged
merged 2 commits into from
May 5, 2022
Merged

Install deps and project in one go #4

merged 2 commits into from
May 5, 2022

Commits on May 4, 2022

  1. Install deps and project in one go 

    This works around a change in poetry 1.2; see explanation here:
matrix-org/synapse#12626 (comment)

I had originally made the "install deps" and "install project" steps
separate, to allow us to skip the installing deps bit if there was a
cache hit. Maintaining that approach would now be painful because I'd
need two different `poetry install` invocations: one with extras and one
without. And it only saved us 1 or 2 seconds per run.
    David Robertson committed May 4, 2022
    Configuration menu
    Copy the full SHA
    f67eafb View commit details
    Browse the repository at this point in the history

  2. Note that the lockfile check fails on poetry 1.2 

    but we want to leave it doing so for Reasons
    David Robertson committed May 4, 2022
    Configuration menu
    Copy the full SHA
    35ec362 View commit details
    Browse the repository at this point in the history