Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix being unable to install with no extras #6

Merged
merged 1 commit into from
May 6, 2022
Merged

Fix being unable to install with no extras #6

merged 1 commit into from
May 6, 2022

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson requested a review from a team as a code owner May 6, 2022 01:18
@DMRobertson
Copy link
Contributor Author

After merge, create v1.1.4 tag/release, then move the v1 tag forward.

@DMRobertson DMRobertson mentioned this pull request May 6, 2022
Merged
anoadragon453
anoadragon453 approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the poetry docs also seem to suggest that not including --no-root will install the deps in editable mode.

@DMRobertson DMRobertson merged commit 1417468 into release/v1 May 6, 2022
@DMRobertson DMRobertson deleted the dmr/fix-install-nodeps branch May 6, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DMRobertson @anoadragon453