Supress membership field on MSC4115 #421
Comments
kegsay
added a commit
that referenced
this issue
Apr 24, 2024
With integration tests. This is required because this field is scoped per-v2-user, but because the proxy deduplicates events it means we might see the membership value for a different user. We can't set this field correctly as we lack that information, so rather than lie to clients instead just delete the field. Fixes #421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Part of element-hq/element-meta#2317
Servers that support MSC4115 will be sending down a new key
unsigned.membershipthat represents:This is incompatible with sliding sync's current architecture, which deduplicates events in the events table. This means Alice could receive the event first, with
unsigned.membershiprepresenting Alice's membership, and then we could serve that same event to Bob. This results in sliding sync lying about this value to clients. We should ensure that we strip this key for now.Longer term, we need to add a new table to track this membership value for each user for each event and then repopulate it when the user connects to the proxy.
The text was updated successfully, but these errors were encountered: