Allow store-invite servlet to handle args via query param or json body #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As @babolivier mentioned, since the code from this PR is already in the mainline branch, it'll be brought in when we do the mainline->dinsic merge anyways. So let's just cherry-pick the mainline commit instead to ease merging efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since at least IS spec r0.1.0,
POST /_matrix/identity/api/v1/store-invitehas sent invite parameters via JSON body.Thus the code currently in the dinsic branch pulls from
request.argswhich is an empty dict.Things have been updated in the master branch to parse requests from both query parameter and json body using the
get_argsfunction, but the dinsic branch is still using query parameters only.This PR ports the fix over from mainline.
CI is expected to fail on the dinsic branch.