This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Add the ability to restrict max avatar filesize and content-type #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sytests are failing until sytest-synapse:dinsic docker is fixed. |
erikjohnston
previously requested changes
Dec 9, 2019
erikjohnston
previously requested changes
Dec 11, 2019
synapse/handlers/profile.py
Outdated
| ): | ||
| # Parse the media URI | ||
| try: | ||
| media_id = new_avatar_url.split("/")[-1] |
There was a problem hiding this comment.
This never actually throws btw, since .split will always return at least one thing
There was a problem hiding this comment.
I think this is what I was looking for with the ValueError:
try:
_, media_id = new_avatar_url.split("/")
except ValueError:
raise SynapseError(400, "Invalid avatar URL '%s' supplied" %
new_avatar_url)
| # | ||
| # Note that this only applies to when an avatar is changed globally. | ||
| # Per-room avatar changes are not affected. See allow_per_room_profiles | ||
| # for disabling that functionality. |
There was a problem hiding this comment.
They currently have per-room avatar functionality disabled, thus all avatar changes must be made globally, which the new option will gatekeep.
anoadragon453
requested review from
erikjohnston
and removed request for
erikjohnston
erikjohnston
approved these changes
Dec 12, 2019
This was referenced Jan 27, 2022
babolivier
added a commit
to matrix-org/synapse
that referenced
this pull request
Jan 28, 2022
Only allow files which file size and content types match configured limits to be set as avatar. Most of the inspiration from the non-test code comes from matrix-org/synapse-dinsic#19
babolivier
added a commit
that referenced
this pull request
Jan 28, 2022
Only allow files which file size and content types match configured limits to be set as avatar. Most of the inspiration from the non-test code comes from #19
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to prevent users from changing their avatar to something that's greater than a maximum size and/or is not a within a whitelist of file mimetypes.