Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Fix harmless exception in port DB script (#15814)
Browse files Browse the repository at this point in the history
The port DB script would try and run database background tasks, which
could fail if the data they acted on was in the process of being ported.
These exceptions were non fatal.

Fixes #15789
  • Loading branch information
erikjohnston authored Jun 21, 2023
1 parent 6c749c5 commit 289ce3b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog.d/15814.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix harmless exceptions being printed when running the port DB script.
3 changes: 3 additions & 0 deletions synapse/_scripts/synapse_port_db.py
Original file line number Diff line number Diff line change
Expand Up @@ -1369,6 +1369,9 @@ def main() -> None:
sys.stderr.write("Database must use the 'psycopg2' connector.\n")
sys.exit(3)

# Don't run the background tasks that get started by the data stores.
hs_config["run_background_tasks_on"] = "some_other_process"

config = HomeServerConfig()
config.parse_config_dict(hs_config, "", "")

Expand Down

0 comments on commit 289ce3b

Please sign in to comment.