Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Narrow the importlib_metadata dependency
Browse files Browse the repository at this point in the history
`pyproject.toml` already has the version guard. I struggled to work out
how to reproduce this guard under setuptools in #12384. But I really
should have persisted there; without this, poetry and setuptools
generate different sets of requirements. That means a poetry-installed
Synapse on a 3.8+ interpreter will fail the runtime dependency checks.
  • Loading branch information
David Robertson committed Apr 6, 2022
1 parent 6fe757d commit 5029079
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion synapse/python_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"packaging>=16.1",
# At the time of writing, we only use functions from the version `importlib.metadata`
# which shipped in Python 3.8. This corresponds to version 1.4 of the backport.
"importlib_metadata>=1.4",
"importlib_metadata>=1.4 ; python_version < '3.8'",
]

CONDITIONAL_REQUIREMENTS = {
Expand Down

0 comments on commit 5029079

Please sign in to comment.