Use servers list approx to send read receipts when in partial state (#…

…14549) Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
matrix-org · Dec 13, 2022 · 5d1d21b · 5d1d21b
1 parent aa389ed
commit 5d1d21b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/changelog.d/14549.misc b/changelog.d/14549.misc
@@ -0,0 +1 @@
+Faster joins: use servers list approximation to send read receipts when in partial state instead of waiting for the full state of the room.
diff --git a/synapse/federation/sender/__init__.py b/synapse/federation/sender/__init__.py
@@ -647,7 +647,7 @@ async def send_read_receipt(self, receipt: ReadReceipt) -> None:
         room_id = receipt.room_id
 
         # Work out which remote servers should be poked and poke them.
-        domains_set = await self._storage_controllers.state.get_current_hosts_in_room(
+        domains_set = await self._storage_controllers.state.get_current_hosts_in_room_or_partial_state_approximation(
             room_id
         )
         domains = [

diff --git a/tests/federation/test_federation_sender.py b/tests/federation/test_federation_sender.py
@@ -38,6 +38,10 @@ def make_homeserver(self, reactor, clock):
             return_value=make_awaitable({"test", "host2"})
         )
 
+        hs.get_storage_controllers().state.get_current_hosts_in_room_or_partial_state_approximation = (
+            hs.get_storage_controllers().state.get_current_hosts_in_room
+        )
+
         return hs
 
     @override_config({"send_federation": True})