Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Remove unspecced DELETE endpoint that modifies room visibility (#13123)
Browse files Browse the repository at this point in the history
  • Loading branch information
santhoshivan23 authored Jun 28, 2022
1 parent 1017f09 commit 6b99a66
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
1 change: 1 addition & 0 deletions changelog.d/13123.removal
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove the unspecced `DELETE /directory/list/room/{roomId}` endpoint, which hid rooms from the [public room directory](https://spec.matrix.org/v1.3/client-server-api/#listing-rooms). Instead, `PUT` to the same URL with a visibility of `"private"`.
11 changes: 0 additions & 11 deletions synapse/rest/client/directory.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,6 @@ async def on_PUT(

return 200, {}

async def on_DELETE(
self, request: SynapseRequest, room_id: str
) -> Tuple[int, JsonDict]:
requester = await self.auth.get_user_by_req(request)

await self.directory_handler.edit_published_room_list(
requester, room_id, "private"
)

return 200, {}


class ClientAppserviceDirectoryListServer(RestServlet):
PATTERNS = client_patterns(
Expand Down

0 comments on commit 6b99a66

Please sign in to comment.