Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Add a comment in _process_received_pdu (#11011)
Browse files Browse the repository at this point in the history
  • Loading branch information
richvdh authored Oct 7, 2021
1 parent 52aefd5 commit 86af6b2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog.d/11011.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clean up some of the federation event authentication code for clarity.
3 changes: 3 additions & 0 deletions synapse/handlers/federation_event.py
Original file line number Diff line number Diff line change
Expand Up @@ -894,6 +894,9 @@ async def _process_received_pdu(
backfilled=backfilled,
)
except AuthError as e:
# FIXME richvdh 2021/10/07 I don't think this is reachable. Let's log it
# for now
logger.exception("Unexpected AuthError from _check_event_auth")
raise FederationError("ERROR", e.code, e.msg, affected=event.event_id)

await self._run_push_actions_and_persist_event(event, context, backfilled)
Expand Down

0 comments on commit 86af6b2

Please sign in to comment.