Merge pull request #5658 from matrix-org/babolivier/is-json

Send 3PID bind requests as JSON data
matrix-org · Jul 10, 2019 · 8ab3444 · 8ab3444
2 parents 953dbb7 + b2a2e96
commit 8ab3444
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/5658.bugfix b/changelog.d/5658.bugfix
@@ -0,0 +1 @@
+Fix 3PID bind requests being sent to identity servers as `application/x-form-www-urlencoded` data, which is deprecated.
diff --git a/synapse/handlers/identity.py b/synapse/handlers/identity.py
@@ -118,7 +118,7 @@ def bind_threepid(self, creds, mxid):
             raise SynapseError(400, "No client_secret in creds")
 
         try:
-            data = yield self.http_client.post_urlencoded_get_json(
+            data = yield self.http_client.post_json_get_json(
                 "https://%s%s" % (id_server, "/_matrix/identity/api/v1/3pid/bind"),
                 {"sid": creds["sid"], "client_secret": client_secret, "mxid": mxid},
             )