This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3129 from matrix-org/matthew/fix_group_dups
remove duplicates from groups tables
- Loading branch information
Showing
1 changed file
with
57 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
# Copyright 2018 New Vector Ltd | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from synapse.storage.engines import PostgresEngine | ||
from synapse.storage.prepare_database import get_statements | ||
|
||
FIX_INDEXES = """ | ||
-- rebuild indexes as uniques | ||
DROP INDEX groups_invites_g_idx; | ||
CREATE UNIQUE INDEX group_invites_g_idx ON group_invites(group_id, user_id); | ||
DROP INDEX groups_users_g_idx; | ||
CREATE UNIQUE INDEX group_users_g_idx ON group_users(group_id, user_id); | ||
-- rename other indexes to actually match their table names.. | ||
DROP INDEX groups_users_u_idx; | ||
CREATE INDEX group_users_u_idx ON group_users(user_id); | ||
DROP INDEX groups_invites_u_idx; | ||
CREATE INDEX group_invites_u_idx ON group_invites(user_id); | ||
DROP INDEX groups_rooms_g_idx; | ||
CREATE UNIQUE INDEX group_rooms_g_idx ON group_rooms(group_id, room_id); | ||
DROP INDEX groups_rooms_r_idx; | ||
CREATE INDEX group_rooms_r_idx ON group_rooms(room_id); | ||
""" | ||
|
||
|
||
def run_create(cur, database_engine, *args, **kwargs): | ||
rowid = "ctid" if isinstance(database_engine, PostgresEngine) else "rowid" | ||
|
||
# remove duplicates from group_users & group_invites tables | ||
cur.execute(""" | ||
DELETE FROM group_users WHERE %s NOT IN ( | ||
SELECT min(%s) FROM group_users GROUP BY group_id, user_id | ||
); | ||
""" % (rowid, rowid)) | ||
cur.execute(""" | ||
DELETE FROM group_invites WHERE %s NOT IN ( | ||
SELECT min(%s) FROM group_invites GROUP BY group_id, user_id | ||
); | ||
""" % (rowid, rowid)) | ||
|
||
for statement in get_statements(FIX_INDEXES.splitlines()): | ||
cur.execute(statement) | ||
|
||
|
||
def run_upgrade(*args, **kwargs): | ||
pass |