Fix incorrect exception handling in KeyUploadServlet.on_POST

Introduced in #7556
matrix-org · May 22, 2020 · ff8cde5 · ff8cde5
1 parent f426969
commit ff8cde5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/7563.misc b/changelog.d/7563.misc
@@ -0,0 +1 @@
+Stop logging some expected HTTP request errors as exceptions.
diff --git a/synapse/app/generic_worker.py b/synapse/app/generic_worker.py
@@ -214,7 +214,7 @@ async def on_POST(self, request, device_id):
                     self.main_uri + request.uri.decode("ascii"), body, headers=headers
                 )
             except HttpResponseException as e:
-                raise e.to_synapse() from e
+                raise e.to_synapse_error() from e
             except RequestSendFailed as e:
                 raise SynapseError(502, "Failed to talk to master") from e