Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

FederationRateLimiter's queue works backwards #3524

Closed
richvdh opened this issue Jul 12, 2018 · 1 comment
Closed

FederationRateLimiter's queue works backwards #3524

richvdh opened this issue Jul 12, 2018 · 1 comment

Comments

@richvdh
Copy link
Member

richvdh commented Jul 12, 2018

so we end up processing the newest requests first and the oldest ones last. which is silly.
@Half-Shot
Copy link
Collaborator

Looking at logging from mx.org side, it looks like sending federation gives up with a ResponseNeverReceived

2018-07-13 00:59:47,661 - synapse.http.matrixfederationclient - 222 - WARNING - None - {PUT-O-1064715} Sending request failed to half-shot.uk: PUT matrix://half-shot.uk/_matrix/federation/v1/send/1531394952235/: ResponseNeverReceived:[CancelledError()]

@richvdh richvdh mentioned this issue Jul 13, 2018
Open
richvdh added a commit that referenced this issue Jul 13, 2018
@richvdh
Make FederationRateLimiter queue requests properly
33b40d0 
popitem removes the *most recent* item by default [1]. We want the oldest.

Fixes #3524

[1]: https://docs.python.org/2/library/collections.html#collections.OrderedDict.popitem
@richvdh richvdh mentioned this issue Jul 13, 2018
Merged
@richvdh richvdh closed this as completed Jul 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @Half-Shot