Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Kill broken and unused FederationServer.on_query_auth_request #6997

Closed
clokep opened this issue Feb 26, 2020 · 5 comments
Closed

Kill broken and unused FederationServer.on_query_auth_request #6997

clokep opened this issue Feb 26, 2020 · 5 comments
Assignees
Labels
A-Spec-Compliance places where synapse does not conform to the spec

Comments

@clokep
Copy link
Member

clokep commented Feb 26, 2020

We talked a bit about FederationBase calling a FederationClient method on Matrix, wanted to capture the results from rich:

I'm pretty sure I decided that FederationServer.on_query_auth_request had been broken forever and needed to die, which means that _check_sigs_and_hash_and_fetch can move to FederationClient
some more context: _on_query_auth_request implements an undocumented, unused REST endpoint

Originally posted by @clokep in #6996 (comment)

@clokep
Copy link
Member Author

clokep commented Feb 26, 2020

While researching this it seems it is actually specced: https://matrix.org/docs/spec/server_server/r0.1.3#post-matrix-federation-v1-query-auth-roomid-eventid

We think it is unused, but will need to check that. We'll also need to write an MSC to remove it from the protocol.

@clokep clokep self-assigned this Feb 26, 2020
@clokep
Copy link
Member Author

clokep commented Feb 27, 2020

Note that the implementation of these functions right now is confusing. FederationBase calls get_pdu, which is actually part of FederationClient.

In order to move this code to FederationClient the query_auth endpoint needs to be cleaned up.

@clokep
Copy link
Member Author

clokep commented Feb 28, 2020

It looks like the client portion of this was removed in #6214 as part of 1.5.0rc1.

@clokep
Copy link
Member Author

clokep commented Mar 3, 2020

@neilisfragile neilisfragile added the A-Spec-Compliance places where synapse does not conform to the spec label Mar 9, 2020
@clokep
Copy link
Member Author

clokep commented Mar 17, 2020

Fixed by #7026.

@clokep clokep closed this as completed Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Spec-Compliance places where synapse does not conform to the spec
Projects
None yet
Development

No branches or pull requests

2 participants