Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

OpenID Connect client_secret should be optional #9212

Closed
tmortagne opened this issue Jan 23, 2021 · 2 comments · Fixed by #9549
Closed

OpenID Connect client_secret should be optional #9212

tmortagne opened this issue Jan 23, 2021 · 2 comments · Fixed by #9549
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@tmortagne
Copy link
Contributor

I'm surprised to see client_secret documented as required since it's not really the case in the OIDC protocol even if it's definitely a good practice especially for big public providers which often do require it.
@richvdh
Copy link
Member

richvdh commented Jan 25, 2021

agreed. Happy to look at a PR which makes it optional.

@richvdh
Copy link
Member

richvdh commented Jan 25, 2021

actually I can probably just do it as part of #9220

@anoadragon453 anoadragon453 added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jan 26, 2021
@clokep clokep added S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. and removed T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Feb 5, 2021
@richvdh richvdh mentioned this issue Mar 4, 2021
Merged
richvdh added a commit that referenced this issue Mar 9, 2021
@richvdh
JWT OIDC secrets for Sign in with Apple (#9549)
eaada74 
Apple had to be special. They want a client secret which is generated from an EC key.

Fixes #9220. Also fixes #9212 while I'm here.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JWT OIDC secrets for Sign in with Apple matrix-org/synapse
4 participants
@tmortagne @clokep @anoadragon453 @richvdh