Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve validation for send_{join,leave,knock} #10225

Merged
merged 8 commits into from
Jun 24, 2021
Merged

Improve validation for send_{join,leave,knock} #10225

merged 8 commits into from
Jun 24, 2021

Commits on Jun 23, 2021

  1. Factor out common parts of FederationHandler.send_join/send_leave/sen… 

    …d_knock

three copies of basically the same code :/
    @richvdh
    richvdh committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    b4a2429 View commit details
    Browse the repository at this point in the history

  2. Inline FederationHandler.on_send_join_request 

    this is a bit simpler.
    @richvdh
    richvdh committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    d45ba1a View commit details
    Browse the repository at this point in the history

  3. Factor out common parts of FederationServer.on_send_join and on_send_… 

    …leave
    @richvdh
    richvdh committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    8ef8652 View commit details
    Browse the repository at this point in the history

  4. More validation for send_join and send_leave 

    ... make sure it's actually a join/leave event.
    @richvdh
    richvdh committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    d52353e View commit details
    Browse the repository at this point in the history

  5. Also validate the room id matches

    @richvdh
    richvdh committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    54eae70 View commit details
    Browse the repository at this point in the history

  6. Use _on_send_membership_event to handle knock events

    @richvdh
    richvdh committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    904db5b View commit details
    Browse the repository at this point in the history

  7. changelog

    @richvdh
    richvdh committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    c25da76 View commit details
    Browse the repository at this point in the history

  8. Check that state_key matches sender

    @richvdh
    richvdh committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    09aa2a1 View commit details
    Browse the repository at this point in the history