Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Clarifications and small fixes to to-device related code #11247

Merged
merged 11 commits into from
Nov 9, 2021
Merged

Clarifications and small fixes to to-device related code #11247

merged 11 commits into from
Nov 9, 2021

Commits on Nov 4, 2021

  1. Add some comments to help explain things

    @anoadragon453
    anoadragon453 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    1412b15 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary optional type hint 

    We never pass None to this function, so let's tighten up the typing.
    @anoadragon453
    anoadragon453 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    02b716d View commit details
    Browse the repository at this point in the history

  3. Don't shadow the built-in 'type'

    @anoadragon453
    anoadragon453 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    3cdcd87 View commit details
    Browse the repository at this point in the history

  4. changelog

    @anoadragon453
    anoadragon453 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    bb5bc65 View commit details
    Browse the repository at this point in the history

  5. Pass users to notify_interesteed_services_ephemeral in tests

    @anoadragon453
    anoadragon453 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    23822d5 View commit details
    Browse the repository at this point in the history

  6. Clarify opt-in ephemeral events comment

    @anoadragon453
    anoadragon453 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    d7be69b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. let logger.info handle the substitution

    @anoadragon453
    anoadragon453 committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    ab9e025 View commit details
    Browse the repository at this point in the history

  2. max_stream_id -> last_stream_id

    @anoadragon453
    anoadragon453 committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    90c0de7 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @anoadragon453 @clokep
    anoadragon453 and clokep authored Nov 8, 2021
    Configuration menu
    Copy the full SHA
    691a542 View commit details
    Browse the repository at this point in the history

  2. instantiate stream_pos in get_new_device_msgs_for_remote

    @anoadragon453
    anoadragon453 committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    33cced2 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Clarify comment of stream limit check

    @anoadragon453
    anoadragon453 committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    a25c8dd View commit details
    Browse the repository at this point in the history