Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix spurious warning when fetching state after a missing prev event #13258

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/13258.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix spurious warning when fetching state after a missing prev event.
3 changes: 3 additions & 0 deletions synapse/handlers/federation_event.py
Original file line number Diff line number Diff line change
Expand Up @@ -1036,6 +1036,9 @@ async def _get_state_ids_after_missing_prev_event(
# XXX: this doesn't sound right? it means that we'll end up with incomplete
# state.
failed_to_fetch = desired_events - event_metadata.keys()
# `event_id`'s missing from `event_metadata` because it's not necessarily a
squahtx marked this conversation as resolved.
Show resolved Hide resolved
# state event. We've already checked that we've fetched it above.
failed_to_fetch.discard(event_id)
if failed_to_fetch:
logger.warning(
"Failed to fetch missing state events for %s %s",
Expand Down