Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix stub return type of PushRuleEvaluator.run #14451

Merged
merged 5 commits into from
Nov 16, 2022
Merged

Fix stub return type of PushRuleEvaluator.run #14451

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
528839f
Fix stub return type of PushRuleEvaluator.run
anoadragon453 Nov 15, 2022
ab1abfa
changelog
anoadragon453 Nov 15, 2022
e9730e9
Switch to Union[dict, str] instead
anoadragon453 Nov 15, 2022
080c904
dict -> Mapping
anoadragon453 Nov 15, 2022
6dc4951
Remove unused import
anoadragon453 Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/14451.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix an incorrect stub return type for `PushRuleEvaluator.run`.
2 changes: 1 addition & 1 deletion stubs/synapse/synapse_rust/push.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ class PushRuleEvaluator:
push_rules: FilteredPushRules,
user_id: Optional[str],
display_name: Optional[str],
) -> Collection[dict]: ...
) -> Collection[Union[dict, str]]: ...