This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow selecting "prejoin" events by state keys #14642
Allow selecting "prejoin" events by state keys #14642
Changes from 8 commits
f03b305
c801ce7
8ed2d93
eb0bbbe
c6199a3
ddc563c
33a559f
a5f6178
d4b86c1
fe30c5d
1bc0f13
11124ed
af032d2
837f6c2
23ca964
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can
state_key
beNone
here? do we need to guard against that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if someone specifies an entry consisting only of an event type.
No, it's a valid input that's explicitly handled by
.add(None)
, seesynapse/synapse/config/api.py
Lines 50 to 52 in c801ce7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't particularly neat, but it gets the job done.