This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Wait for streams to catch up when processing HTTP replication. #14820
Merged
Commits on Jan 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a2d8ed5 - Browse repository at this point
Copy the full SHA a2d8ed5View commit details -
Wait for streams to catch up when processing HTTP replication.
This should hopefully mitigate a class of races where data gets out of sync due a HTTP replication request racing with the replication streams.
Configuration menu - View commit details
-
Copy full SHA for e36ff7b - Browse repository at this point
Copy the full SHA e36ff7bView commit details -
Don't wait for streams when asking for stream updates
Otherwise we can deadlock as we wait for the positions we are asking for.
Configuration menu - View commit details
-
Copy full SHA for 7f2700b - Browse repository at this point
Copy the full SHA 7f2700bView commit details -
Send out
POSITION
commands for all streamsThis is so that if a stream advances their position *without* writing a row to the stream, other instances will get told about the updated position quickly anyway.
Configuration menu - View commit details
-
Copy full SHA for 473cc10 - Browse repository at this point
Copy the full SHA 473cc10View commit details -
Change ID generator to return position of last write
This is already true when asking for stream positions of other instances, but for our own instance we have fudged it. Changing this should be fine (it was just an optimisation), and I don't think it should have much impact in practice at all. The reason to do this is so that when tell remotes what our current position is we only include *our* writes, rather than writes of other instances. This reduces delays when the remote instance is waiting for stream positions to update. In practice, this is probably only a problem for tests, though we may as well do it for all of them.
Configuration menu - View commit details
-
Copy full SHA for a03ee6e - Browse repository at this point
Copy the full SHA a03ee6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6edfd62 - Browse repository at this point
Copy the full SHA 6edfd62View commit details
Commits on Jan 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 01ae502 - Browse repository at this point
Copy the full SHA 01ae502View commit details -
Configuration menu - View commit details
-
Copy full SHA for ace2b8c - Browse repository at this point
Copy the full SHA ace2b8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20590ce - Browse repository at this point
Copy the full SHA 20590ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a0a51e - Browse repository at this point
Copy the full SHA 7a0a51eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.