Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Clean-up presence code #16092

Merged
merged 9 commits into from
Aug 10, 2023
Merged

Clean-up presence code #16092

merged 9 commits into from
Aug 10, 2023

Conversation

clokep
Copy link
Member

@clokep clokep commented Aug 9, 2023

This is split out of #16066 / things I learned while doing that. It makes a handful of changes which are unrelated, but all various clean-ups.

Should be reviewable commit-by-commit.

@clokep clokep marked this pull request as ready for review August 9, 2023 19:03
@clokep clokep requested a review from a team as a code owner August 9, 2023 19:03
H-Shay
H-Shay approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@H-Shay H-Shay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look very reasonable, thanks for the organized commit history, made it very easy to review!

@clokep clokep merged commit efd4d06 into develop Aug 10, 2023
37 checks passed
@clokep clokep deleted the clokep/presence-clean-up branch August 10, 2023 11:39
@clokep
Copy link
Member Author

clokep commented Aug 10, 2023

Thanks for the fast review!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@H-Shay H-Shay H-Shay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clokep @H-Shay