This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add tests for restoring the presence state after a restart. #16151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
clokep/presence-restore-tests
branch
from
4a63edf
to
0b6af09
Compare
clokep
force-pushed
the
clokep/presence-restore-tests
branch
from
0b6af09
to
130764c
Compare
clokep
commented
Aug 22, 2023
| [ | ||
| (PresenceState.BUSY, PresenceState.BUSY), | ||
| (PresenceState.ONLINE, PresenceState.ONLINE), | ||
| (PresenceState.UNAVAILABLE, PresenceState.UNAVAILABLE), |
There was a problem hiding this comment.
This one is actually wrong for the same things that #16066 fixes -- we restore to an "online" state, so an "unavailable" state shouldn't override that.
H-Shay
approved these changes
Aug 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spun out of #16066, these are some additional tests to ensure that the restored presence state makes sense after a restart.
Requires #16150.