Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix appservices being unable to handle to_device messages for multiple users #16251

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Fix appservices being unable to handle to_device messages for multiple users #16251

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5fa239d
Drop single filter for user_id
Half-Shot Sep 5, 2023
867c9b0
changelog
Half-Shot Sep 5, 2023
93a9384
Merge branch 'develop' into hs/fix-multiple-users-in-_get_device_mess…
Half-Shot Sep 5, 2023
4ba58ab
fix changelog
Half-Shot Sep 5, 2023
08ab344
Add test_application_services_receive_local_to_device_for_many_users
Half-Shot Sep 5, 2023
b408a22
Fix docs
Half-Shot Sep 5, 2023
fbefeba
Update tests/handlers/test_appservice.py
Half-Shot Sep 5, 2023
6f18657
Lint
Half-Shot Sep 5, 2023
921c60c
Merge branch 'develop' into hs/fix-multiple-users-in-_get_device_mess…
Half-Shot Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/16251.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a longstanding bug where appservices using MSC2049 to receive to_device messages, would only get messages for one user.
Half-Shot marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion synapse/storage/databases/main/deviceinbox.py
View file
Open in desktop
Half-Shot marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ def get_device_messages_txn(
table="devices",
column="user_id",
iterable=user_ids_to_query,
keyvalues={"user_id": user_id, "hidden": False},
keyvalues={"hidden": False},
retcols=("device_id",),
)

Expand Down
Loading