This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Include a default configuration file in the 'docs' directory. #4791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4791 +/- ##
===========================================
- Coverage 75.13% 75.02% -0.11%
===========================================
Files 340 340
Lines 34918 35134 +216
Branches 5722 5797 +75
===========================================
+ Hits 26234 26358 +124
- Misses 7072 7152 +80
- Partials 1612 1624 +12 |
erikjohnston
approved these changes
Mar 4, 2019
| plugins: | ||
| - docker#v3.0.1: | ||
| image: "python:3.6" | ||
|
|
There was a problem hiding this comment.
This seemed to take over 1 minute, so I'd be tempted to move after the wait
There was a problem hiding this comment.
yeah, it's downloading and installing all of the python deps. It seems a shame that (a) we can't do better caching here, and (b) the virtualenv isn't shared between the builds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works by simply checking a file into git, and adding a CI job which will remind us to update it if we forget.
Fixes #1433.