Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't log GCs at INFO #5557

Merged
merged 4 commits into from
Jun 28, 2019
Merged

Don't log GCs at INFO #5557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be7f3bd
oh my god shut up
hawkowl Jun 26, 2019
3a393ba
changelog
hawkowl Jun 26, 2019
a03b24b
debug when 0, but print level 1 and 2 GCs
hawkowl Jun 28, 2019
d101492
debug when 0, but print level 1 and 2 GCs
hawkowl Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5557.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Logging when running GC collection on generation 0 is now at the DEBUG level, not INFO.
5 changes: 4 additions & 1 deletion synapse/metrics/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,10 @@ def f(*args, **kwargs):
counts = gc.get_count()
for i in (2, 1, 0):
if threshold[i] < counts[i]:
logger.info("Collecting gc %d", i)
if i == 0:
logger.debug("Collecting gc %d", i)
else:
logger.info("Collecting gc %d", i)

start = time.time()
unreachable = gc.collect(i)
Expand Down