This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Workaround for error when fetching notary's own key #6620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already get the Site via the Channel, so there's no need for a dedicated RequestFactory: we can just use the right constructor.
As a notary server, when we return our own keys, include all of our signing keys in verify_keys. This is a workaround for #6596.
richvdh
added a commit
that referenced
this pull request
Jan 7, 2020
This was ill-advised. We can't modify verify_keys here, because the response object has already been signed by the requested key. Furthermore, it's somewhat unnecessary because existing versions of Synapse (which get upset that the notary key isn't present in verify_keys) will fall back to a direct fetch via `/key/v2/server`.
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '18674eebb': Workaround for error when fetching notary's own key (#6620)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a notary server, when we return our own keys, include all of our signing
keys in verify_keys.
This is a workaround for #6596.
(based on #6619)