This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Prevent 0-member/null room_version rooms from appearing in group room queries #7465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
clokep
approved these changes
May 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4891
Prevents group servlets from acting on rooms without any members (dead rooms) or with a NULL/empty
room_versionstring.The added docstrings may help in our community rewrite later on as we'll have a better understanding of the current community functionality.
TODO:
local_users_in_roomis not 0.I'm not sure whether this is a plaster on an existing problem or not, but either way it's a quick fix to a communities problems that will eventually be written over with comms v2 anyways.