This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Allow to use higher versions of prometheus_client #7780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what the failure in "buildkite/synapse/newspaper-newsfile" means |
richvdh
suggested changes
Jul 3, 2020
it means you haven't included a changelog fragment. Please see CONTRIBUTING.md. |
richvdh
added
the
X-Awaiting-Changes
okurz
force-pushed
the
fix/prometheus
branch
2 times, most recently
from
6ed477d
to
6154bb6
Compare
auscompgeek
reviewed
Jul 3, 2020
Fixes matrix-org#7641 The package was pinned to <0.8.0 without an obvious reasoning with 7ad1d76 in matrix-org#5636 while the version selection looks to just try to exclude an arbitrary next minor version number that might introduce API breaking changes. Selecting the next minor number might be a good conservative selection. Downstream distributions already reported success patching out the version requirements. This also fixes the integration of upgraded packages into openSUSE packages, e.g. for openSUSE Tumbleweed which already ships prometheus_client >= 0.8 . Signed-off-by: Oliver Kurz <okurz@suse.de>
richvdh
removed
the
X-Awaiting-Changes
|
just waiting for CI here; we can merge once it is green |
I can recommend https://mergify.io/ to do that automatically :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7641
The package was pinned to <0.8.0 without an obvious reasoning with
7ad1d76
in #5636
while the version selection looks to just try to exclude an arbitrary
next minor version number that might introduce API breaking changes.
Selecting the next minor number might be a good conservative selection.
Downstream distributions already reported success patching out the version
requirements.
This also fixes the integration of upgraded packages into openSUSE packages,
e.g. for openSUSE Tumbleweed which already ships prometheus_client >= 0.8 .