This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Correctly retry replication HTTP requests on timeout #8412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/repl_http_timeout
branch
from
1e9e4aa
to
11149c8
Compare
richvdh
suggested changes
Sep 28, 2020
| @@ -196,6 +196,9 @@ async def send_request(instance_name="master", **kwargs): | |||
| except CodeMessageException as e: | |||
| if e.code != 504 or not cls.RETRY_ON_TIMEOUT: | |||
| raise | |||
| except RequestTimedOutError: | |||
There was a problem hiding this comment.
RequestTimedOutError is a CodeMessageException, so this won't get hit (and is redundant)
There was a problem hiding this comment.
Gah, I'm getting confused with how the federation client works :/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, in conjunction with #8400, should hopefully fix #7792. The idea being that we'll keep retrying when we get a timeout (rather than raising).