Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop bionic from docker builds and add focal #1181

Merged
merged 5 commits into from
Jan 7, 2022
Merged

Drop bionic from docker builds and add focal #1181

merged 5 commits into from
Jan 7, 2022

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Dec 21, 2021

Related to #11552, drops bionic from the docker builds which uses EOL python 3.6 and add focal, which uses python 3.9.

@H-Shay H-Shay requested a review from a team as a code owner December 21, 2021 22:15
@H-Shay H-Shay removed the request for review from a team December 21, 2021 22:17
@H-Shay H-Shay marked this pull request as draft December 21, 2021 22:17
@callahad
Copy link
Contributor

which uses python 3.9.

I think Focal is actually on 3.8 by default: https://packages.ubuntu.com/focal/python3

@callahad
Copy link
Contributor

Curious chicken/egg problem with CI: it wants to pull the images that you're naming in this PR, but since the PR hasn't yet been merged, the images haven't yet been built.

@callahad
Copy link
Contributor

I suspect we'll need to somewhat blindly merge, and then submit a dummy follow-up PR to make sure it works.

@H-Shay
Copy link
Contributor Author

H-Shay commented Dec 21, 2021 •
edited
Loading

Well I could do a manual push and build but there is an issue with the testing image being built which is causing problems: see #1114

@H-Shay H-Shay mentioned this pull request Jan 4, 2022
Merged
@H-Shay H-Shay marked this pull request as ready for review January 5, 2022 21:48
@H-Shay H-Shay requested a review from a team January 5, 2022 21:49
@H-Shay
Copy link
Contributor Author

H-Shay commented Jan 5, 2022

This is now unblocked.

@DMRobertson
Copy link
Contributor

Well I could do a manual push and build but there is an issue with the testing image being built which is causing problems: see #1114

I think ops are keen for us to avoid personally publishing artefacts where possible.

DMRobertson
DMRobertson reviewed Jan 7, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand why CI is now passing. It manages to download the image docker.io/matrixdotorg/sytest-synapse:focal, but that shouldn't have been published until this gets merged(?)

DMRobertson
DMRobertson approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see: you manually invoked the docker workflow on this PR via github's UI.

I can see here that Bionic was pushed at 5:30pm but Focal, Buster and Testing were pushed in a batch at 6:20. I think that, plus green CI is evidence enough that this is working!

@H-Shay H-Shay merged commit 39f3805 into develop Jan 7, 2022
@H-Shay H-Shay deleted the shay/add_focal branch January 7, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@H-Shay @callahad @DMRobertson