Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change event shape to match MSC3898 #70

Merged
merged 10 commits into from
Dec 12, 2022
Merged

Change event shape to match MSC3898 #70

merged 10 commits into from
Dec 12, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Dec 10, 2022 •
edited
Loading

@SimonBrandner
Change event shape to match MSC3898
8350bef 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner force-pushed the SimonBrandner/feat/event-shape branch 2 times, most recently from 3629a37 to 5436d37 Compare December 10, 2022 15:45
@SimonBrandner
Update mautrix-go
269963b 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner mentioned this pull request Dec 10, 2022
Merged
@SimonBrandner SimonBrandner marked this pull request as ready for review December 12, 2022 09:10
@SimonBrandner SimonBrandner requested a review from a team December 12, 2022 09:10
dbkr
dbkr approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwiswe lgtm

pkg/conference/config.go Show resolved Hide resolved
pkg/conference/data_channel_message_processor.go Outdated Show resolved Hide resolved
pkg/config/config.go Show resolved Hide resolved
@SimonBrandner
Add trace log
a38dd15 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Add TODO
cc75a83 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
daniel-abramov
daniel-abramov reviewed Dec 12, 2022
View reviewed changes
pkg/conference/config.go Show resolved Hide resolved
pkg/conference/data_channel_message_processor.go Outdated Show resolved Hide resolved
pkg/conference/data_channel_message_processor.go Outdated Show resolved Hide resolved
pkg/conference/data_channel_message_processor.go Outdated Show resolved Hide resolved
pkg/conference/matrix_message_processor.go Outdated Show resolved Hide resolved
pkg/peer/webrtc.go Outdated Show resolved Hide resolved
@SimonBrandner
Add full-stop
7be5186 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Use switch statement
23d9294 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Move TODO
450d195 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Pass everything from conference
098be79 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Simplify how we handle ping and pong
90ae985 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Add FIXME
20e5dfc 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner merged commit 4ae7b80 into main Dec 12, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/feat/event-shape branch December 12, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@daniel-abramov daniel-abramov daniel-abramov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update events shape to match the MSC
3 participants
@SimonBrandner @dbkr @daniel-abramov