Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(myph): adding support for more options #1

Merged
merged 7 commits into from
Nov 23, 2023
Merged

feat(myph): adding support for more options #1

merged 7 commits into from
Nov 23, 2023

Conversation

djnnvx
Copy link
Member

@djnnvx djnnvx commented Nov 23, 2023

  • split the two loaders into two different scripts, so that code is easier to manage
  • added support for most options for myph 1.1 (--encryption flag not included)
  • edited the readme to meme a little bit lol

@djnnvx
feat(myph): adding support for more options
2b52aa9 
* split the two loaders into two different scripts, so that code is
  easier to manage
* added support for most options for myph 1.1 (`--encryption` flag not
  included)
@djnnvx djnnvx requested a review from jenaye November 23, 2023 00:12
@djnnvx djnnvx self-assigned this Nov 23, 2023
jenaye
jenaye requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@jenaye jenaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, it looks like CRT twice :
image

may this help you :

image

Also, as the scripts share globals, I get seg faults if I install the 2 plugins,
but independently they work fine

in any case nice work users can now be more precise in creating their binary, thx for that @djnnvx :)

@djnnvx
fix(loaders): prevent global variables from being shared
a32654c 
there is a bug when using both loaders, which makes the client segfault.
I assume this is because memory is shared between both of them, which
makes it crash. issue has been addressed and fixed
@djnnvx
fix(221b): adding missing havocui.createtab()
d4ba7e6
@djnnvx
Copy link
Member Author

djnnvx commented Nov 23, 2023

Hey, it looks like CRT twice : image

may this help you :

image

Also, as the scripts share globals, I get seg faults if I install the 2 plugins, but independently they work fine

in any case nice work users can now be more precise in creating their binary, thx for that @djnnvx :)

"CRT" is shown twice because this is the default value. I've removed the log message as you wanted & fixed the issue with 221b, let me know if there is anything else to address before we can merge this

@djnnvx djnnvx requested a review from jenaye November 23, 2023 14:44
@djnnvx djnnvx merged commit 27854ec into main Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenaye jenaye jenaye approved these changes

Assignees

@djnnvx djnnvx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djnnvx @jenaye