Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Alias utils when loading from module source #8

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

matt-d-rat
Copy link
Owner

Description

This PR fixes an issue when loading react-middle-truncate from module source where by the utils folder could not be found (introduced in v1.0.1).

Opted to move the utils folder under the library folder and not rely on webpack aliases for this.

Screenshots

A picture speaks a thousand words, so if applicable please provide the following screenshots to demonstrate your change:

  • Unit tests have passed.
  • Code linting has passed.

@matt-d-rat matt-d-rat added the bug Something isn't working label Aug 19, 2019
@matt-d-rat matt-d-rat self-assigned this Aug 19, 2019
@matt-d-rat matt-d-rat merged commit 316df22 into master Aug 19, 2019
@matt-d-rat matt-d-rat deleted the fix/module-resolve-utils branch August 19, 2019 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant