Merge dev into MDv2-farm #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include a more explicit C string length variable
abort_error_level should be greater than 0 so that error_status of 0 doesn’t cause a false error
Rather than aborting the process completely
This is not a Python problem, but its a human eyes problem.
First call FAST_End to deallocate internal arrays and then call FAST_DeallocateTurbines to free up the Turbine array
Removes the requirement to pass TMax and InitInpAry since passing TMax overrides the input file value. This commit preserves this functionality, but makes it optional. The system TMax is also now returned so that calling-codes can determine how many time steps to loop over. NOTE: this may break any codes using FAST_Library.h as that header does not support the optional arguments to FAST_Sizes
This is currently used during the linearization simulations with CalcSteady enabled. After do NLinTimes steps, the simluation should simply end. This is currently already handled in FAST_Prog, and this commits adds the same behavior in FAST_Library
# Conflicts: # glue-codes/python/OpenFAST.py
Storing the error status on the class was causing it to be overwritting when doing the deinitialization routines. The error would be caught, but it would then report back Error 0: <empty string>.
This was checking for an error in the openfastlib but `fatal_error` is a function not an attribute so the if-statement was evaluating to True. In any case, the errors should be handled in the library.
Adds more of the exising OpenFAST regression tests. Only the tests that have dt and dt_out matching are compatible. The FAST_Library outputs values at each call to FAST_Update, but the output files from FAST_Prog are written at dt_out intervals. The Python interface would have to parse dt_out and export files similarly to match the existing regression test baselines.
…-rtest r-test: Remove -m64 in CMAKE_Fortran_FLAG from r-test
Improvements to regression test python scripts
Seg Fault due to hub model and external inflow
AeroAcoustics: fix BL-thickness for heavily-tripped airfoil
…InputLine HD: increase max length of line read from kinematics files
…OpenFAST tests that were removed. - 5MW_ITIBarge_DLL_WTurb_WavesIrr_py - hd_5MW_ITIBarge_DLL_WTurb_WavesIrr - hd_5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth
This will help a bit in minimizing a race condition during test running. See comments in PR OpenFAST#1199
Use dt_out when storing OpenFAST outputs in Python interface
If a turbine is using SubDyn, the shared moorings connection will be to the platform reference point and not the SubDyn structure. This can lead to some incorrect behaviour if the mooring connections need to be at points on a flexible platform.
@deslaughter found this issue in the PR
Reg-test scripts modification to help avoid race condition and cleanup of caselist
Small improvements for -VTKLin visualization outputs
Fix HD added mass on member end (Close OpenFAST#992)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the latest release (v3.2.0 -- that is currently being posted) into the MDv2-farm branch.
Once this is completed, we can merge MDv2-farm into OpenFAST/dev for the upcoming 3.3.0 release.