Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After copying a lib to the wheel directory, set its writeable bit if necessary #202

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

jvolkman
Copy link
Contributor

@jvolkman jvolkman commented Feb 7, 2024

Some build systems (e.g., Bazel) generate read-only artifacts, and shutil.copy also copies these modes.

Auditwheel has the same logic here.

Copy link
Collaborator

@HexDecimal HexDecimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a pathlib version of this code that I'd prefer over copying from Auditwheel, but that can always be resolved later.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eaba43d) 96.45% compared to head (e624fe9) 96.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   96.45%   96.46%   +0.01%     
==========================================
  Files          15       15              
  Lines        1184     1188       +4     
==========================================
+ Hits         1142     1146       +4     
  Misses         42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HexDecimal HexDecimal merged commit e8d82fb into matthew-brett:master Feb 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants