Stable: Backport external GPS fix #10486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"QNmeaPositionInfoSource supports reporting the accuracy of the horizontal and vertical position. To enable position accuracy reporting an estimate of the User Equivalent Range Error associated with the NMEA source must be set with setUserEquivalentRangeError." Source: https://doc.qt.io/qt-6/qnmeapositioninfosource.html#details Commit 2a9ecab introduced new behaviour that broke use of external GPS. This change fixes the problem reported in mavlink#10271.
Williangalvani
force-pushed
the
gpsfix
branch
from
ca4bede
to
63c2e4e
Compare
patrickelectric
approved these changes
Nov 16, 2022
|
@Williangalvani do we need a new qgc release for this ? If so, there are more things to fix/merge ? |
I would wait for the video recording fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #10374 to fix external gps support in 4.2