Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Eigen to get rid of compiler warnings #8063

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

DonLakeFlyer
Copy link
Contributor

Related to #8061

@MatejFranceskin
Copy link
Collaborator

I still get a lot of these:

/home/matej/src/upstream-qgroundcontrol/libs/mavlink/include/mavlink/v2.0/ardupilotmega/../common/./mavlink_msg_smart_battery_status.h: In function ‘uint16_t mavlink_msg_smart_battery_status_encode_chan(uint8_t, uint8_t, uint8_t, mavlink_message_t*, const mavlink_smart_battery_status_t*)’:
/home/matej/src/upstream-qgroundcontrol/libs/mavlink/include/mavlink/v2.0/ardupilotmega/../common/./mavlink_msg_smart_battery_status.h:178:357: warning: taking address of packed member of ‘__mavlink_smart_battery_status_t’ may result in an unaligned pointer value [-Waddress-of-packed-member]
178 | return mavlink_msg_smart_battery_status_pack_chan(system_id, component_id, chan, msg, smart_battery_status->id, smart_battery_status->capacity_remaining, smart_battery_status->current, smart_battery_status->temperature, smart_battery_status->fault_bitmask, smart_battery_status->time_remaining, smart_battery_status->cell_offset, smart_battery_status->voltages);
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /home/matej/src/upstream-qgroundcontrol/libs/mavlink/include/mavlink/v2.0/ardupilotmega/../common/common.h:1630,
from /home/matej/src/upstream-qgroundcontrol/libs/mavlink/include/mavlink/v2.0/ardupilotmega/ardupilotmega.h:953,
from /home/matej/src/upstream-qgroundcontrol/libs/mavlink/include/mavlink/v2.0/ardupilotmega/mavlink.h:32,
from /home/matej/src/upstream-qgroundcontrol/src/comm/QGCMAVLink.h:24,
from /home/matej/src/upstream-qgroundcontrol/src/qgcunittest/UnitTest.h:24,
from /home/matej/src/upstream-qgroundcontrol/src/FactSystem/FactSystemTestBase.h:17,
from /home/matej/src/upstream-qgroundcontrol/src/FactSystem/FactSystemTestBase.cc:14:
/home/matej/src/upstream-qgroundcontrol/libs/mavlink/include/mavlink/v2.0/ardupilotmega/../common/./mavlink_msg_actuator_output_status.h: In function ‘uint16_t mavlink_msg_actuator_output_status_encode(uint8_t, uint8_t, mavlink_message_t*, const mavlink_actuator_output_status_t*)’:
/home/matej/src/upstream-qgroundcontrol/libs/mavlink/include/mavlink/v2.0/ardupilotmega/../common/./mavlink_msg_actuator_output_status.h:119:173: warning: taking address of packed member of ‘__mavlink_actuator_output_status_t’ may result in an unaligned pointer value [-Waddress-of-packed-member]
119 | return mavlink_msg_actuator_output_status_pack(system_id, component_id, msg, actuator_output_status->time_usec, actuator_output_status->active, actuator_output_status->actuator);
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/home/matej/src/upstream-qgroundcontrol/libs/mavlink/include/mavlink/v2.0/ardupilotmega/../common/./mavlink_msg_actuator_output_status.h: In function ‘uint16_t mavlink_msg_actuator_output_status_encode_chan(uint8_t, uint8_t, uint8_t, mavlink_message_t*, const mavlink_actuator_output_status_t*)’:
/home/matej/src/upstream-qgroundcontrol/libs/mavlink/include/mavlink/v2.0/ardupilotmega/../common/./mavlink_msg_actuator_output_status.h:133:184: warning: taking address of packed member of ‘__mavlink_actuator_output_status_t’ may result in an unaligned pointer value [-Waddress-of-packed-member]
133 | return mavlink_msg_actuator_output_status_pack_chan(system_id, component_id, chan, msg, actuator_output_status->time_usec, actuator_output_status->active, actuator_output_status->actuator);
|
And these:
compiling /home/matej/src/upstream-qgroundcontrol/src/QtLocationPlugin/QGeoCodingManagerEngineQGC.cpp
In file included from /home/matej/Qt/5.12.6/gcc_64/include/QtCore/QVariant:1,
from /home/matej/Qt/5.12.6/gcc_64/include/QtLocation/qgeoserviceprovider.h:40,
from /home/matej/Qt/5.12.6/gcc_64/include/QtLocation/QGeoServiceProvider:1,
from /home/matej/src/upstream-qgroundcontrol/src/QtLocationPlugin/QGeoCodingManagerEngineQGC.h:50,
from /home/matej/src/upstream-qgroundcontrol/src/QtLocationPlugin/QGeoCodingManagerEngineQGC.cpp:47:
/home/matej/Qt/5.12.6/gcc_64/include/QtCore/qvariant.h: In constructor ‘QVariant::QVariant(QVariant&&)’:
/home/matej/Qt/5.12.6/gcc_64/include/QtCore/qvariant.h:273:25: warning: implicitly-declared ‘QVariant::Private& QVariant::Private::operator=(const QVariant::Private&)’ is deprecated [-Wdeprecated-copy]
273 | { other.d = Private(); }
| ^
/home/matej/Qt/5.12.6/gcc_64/include/QtCore/qvariant.h:399:16: note: because ‘QVariant::Private’ has user-provided ‘QVariant::Private::Private(const QVariant::Private&)’
399 | inline Private(const Private &other) Q_DECL_NOTHROW
| ^~~~~~~

@DonLakeFlyer
Copy link
Contributor Author

Those aren't Eigen related?

@dagar
Copy link
Member

dagar commented Nov 25, 2019

Could this be carried as a submodule?

@DonLakeFlyer DonLakeFlyer merged commit c9d3aa7 into mavlink:master Dec 11, 2019
@DonLakeFlyer DonLakeFlyer deleted the Eigen branch December 11, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants