Skip to content

Commit

Permalink
src: Select the data inserted by ! and <a-!>
Browse files Browse the repository at this point in the history
Closes #1468
  • Loading branch information
lenormf authored and mawww committed Mar 5, 2022
1 parent 7061001 commit 85b78dd
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 6 deletions.
4 changes: 2 additions & 2 deletions doc/pages/keys.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -374,10 +374,10 @@ The default command comes from the *|* register by default (See <<registers#,`:d
ignore its output.

*!*::
insert command output before each selection.
insert and select command output before each selection.

*<a-!>*::
append command output after each selection.
append and select command output after each selection.

== Searching

Expand Down
11 changes: 9 additions & 2 deletions src/normal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -765,17 +765,24 @@ void insert_output(Context& context, NormalParams params)
auto& selections = context.selections();
auto& buffer = context.buffer();
const size_t old_main = selections.main_index();
Vector<BufferRange> ins_range;

selections.for_each([&](size_t index, Selection& sel) {
selections.set_main_index(index);
auto [out, status] = ShellManager::instance().eval(
cmdline, context, content(context.buffer(), sel),
ShellManager::Flags::WaitForStdout);

insert(buffer, sel, paste_pos(buffer, sel, mode, false), out);
auto range = insert(buffer, sel, paste_pos(buffer, sel, mode, false), out);
ins_range.push_back(range);
});

selections.set_main_index(old_main);
selections.set(ins_range | transform([&buffer](auto& range) {
if (range.empty())
return Selection{range.begin, range.end};
return Selection{range.begin,
buffer.char_prev(range.end)};
}) | gather<Vector>(), old_main);
});
}

Expand Down
3 changes: 2 additions & 1 deletion src/selection.cc
Original file line number Diff line number Diff line change
Expand Up @@ -399,11 +399,12 @@ void replace(Buffer& buffer, Selection& sel, StringView content)
max = range.end > range.begin ? buffer.char_prev(range.end) : range.begin;
}

void insert(Buffer& buffer, Selection& sel, BufferCoord pos, StringView content)
BufferRange insert(Buffer& buffer, Selection& sel, BufferCoord pos, StringView content)
{
auto range = buffer.insert(pos, content);
sel.anchor() = buffer.clamp(update_insert(sel.anchor(), range.begin, range.end));
sel.cursor() = buffer.clamp(update_insert(sel.cursor(), range.begin, range.end));
return range;
}

void SelectionList::replace(ConstArrayView<String> strings)
Expand Down
2 changes: 1 addition & 1 deletion src/selection.hh
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ void merge_overlapping_selections(Vector<Selection>& selections, size_t& main);
void clamp_selections(Vector<Selection>& sel, const Buffer& buffer);

void replace(Buffer& buffer, Selection& sel, StringView content);
void insert(Buffer& buffer, Selection& sel, BufferCoord pos, StringView content);
BufferRange insert(Buffer& buffer, Selection& sel, BufferCoord pos, StringView content);

struct SelectionList
{
Expand Down

0 comments on commit 85b78dd

Please sign in to comment.