Change all 'flask.ext.login' references to 'flask_login' #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -113,7 +113,7 @@ function. For example:: | |||
| flask.flash('Logged in successfully.') | |||
|
|
|||
| next = flask.request.args.get('next') | |||
| # next_is_valid should check if the user has valid | |||
| # next_is_valid should check if the user has valid | |||
There was a problem hiding this comment.
There's a lot changed in this file that doesn't seem relevant to this patch. It makes it difficult to evaluate the patch on its own and I don't generally think it's good practice to merge commits with irrelevant changes.
There was a problem hiding this comment.
Agreed. I should have reviewed better before PR'ing.
|
Merged with #289 |
|
Thanks, @alanhamlett. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #282.
See pallets/flask#1484 for more information.