Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to direct hamlib #12

Open
darvark opened this issue Jul 11, 2023 · 12 comments
Open

Switch to direct hamlib #12

darvark opened this issue Jul 11, 2023 · 12 comments
Assignees
Labels
enhancement request New feature or request

Comments

@darvark
Copy link

darvark commented Jul 11, 2023

Hi,
can we switch to use directly hamlib instead of fetching data from third party software like flrig? It should simplify cat communication and can be easily extended to add rotor support.
Only cons of such solution is that we have to configure hamlib from not1mm level, but still this would be much closer to n1mm than current solution.

@mbridak
Copy link
Owner

mbridak commented Jul 11, 2023

I'm not opposed to it. I wouldn't do it as a replacement. More like a 3rd option. I personally prefer rigctld. I have it (rigctld) start up as a service in the background and never have to think about it.

@mbridak mbridak added the enhancement request New feature or request label Jul 11, 2023
@darvark
Copy link
Author

darvark commented Jul 11, 2023

Ok, great. I think I can start working on this issue. Eventually we can discuss how I should solve hamlib configuration, should it be new window, textfile, or in current configuration window

@mbridak
Copy link
Owner

mbridak commented Jul 11, 2023

Okay, I made a branch for it.

@mbridak
Copy link
Owner

mbridak commented Jul 11, 2023

All the hamlib specific code should live in cat_interface.py
The settings should live in the same dialog as the other CAT settings.
I'll figure out the dialog.

@mbridak
Copy link
Owner

mbridak commented Jul 11, 2023

Added initial fields to dialog.

Screenshot from 2023-07-11 15-43-08

hamlib_device QComboBox
hamlib_baud QComboBox
hamlib_radio QComboBox
update_devices QPushButton
usehamlib_radioButton QRadioButton

Some more will be needed I assume.

@darvark
Copy link
Author

darvark commented Jul 12, 2023

Generally that's all. In case of any custom settings maybe in the future interface can be extended, but for now it's enough.

One additional question. Why do you query PTT status? Is it needed for anything? Python bindings for hamlib has very poor documentation and it simply won't work in some cases (some rigs doesn't provide information about ptt so hamlib can't get that info)

@mbridak
Copy link
Owner

mbridak commented Jul 12, 2023

Setting PTT state is needed for voice keying.
Polling PTT was/is used when n1mm radio state packets are sent, and will be used if I get around to so2r stuff.

You can just have it return False if it's not available.

@darvark
Copy link
Author

darvark commented Jul 14, 2023

Ok, finally I manage to set and get status of PTT, only setting RF power left. Maybe today I'll push changes as draft for first review (without tests and not aligned to your branch)

@darvark
Copy link
Author

darvark commented Jul 22, 2023

Strange, I'm applying your changes from your branch in configuration.ui file, rebuilding with rebuild.sh script, and still I can't see those new controls in configuration window. Am I missing something?

@mbridak
Copy link
Owner

mbridak commented Jul 22, 2023 via email

@mbridak
Copy link
Owner

mbridak commented Jul 28, 2023

Ah, I think I know why your not seeing it. I think you haven't checked out and applied your changes to the branch created for the issue.

The branch should be called something like 12-switch-to-direct-hamlb

@darvark
Copy link
Author

darvark commented Jul 30, 2023

I've made changes on my own branch and then applied your changes to configuration.ui (I've found only those changes in your branch), so still it should be visible since changes were applied to UI file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants